[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 08 Jul 2016 01:12:42 +0200
From: Gregory CLEMENT <gregory.clement@...e-electrons.com>
To: Stephen Boyd <sboyd@...eaurora.org>
Cc: Mike Turquette <mturquette@...libre.com>,
linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
linux-arm-kernel@...ts.infradead.org,
Jason Cooper <jason@...edaemon.net>,
Andrew Lunn <andrew@...n.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
Nadav Haklai <nadavh@...vell.com>,
Victor Gu <xigu@...vell.com>,
Romain Perier <romain.perier@...e-electrons.com>,
Omri Itach <omrii@...vell.com>,
Marcin Wojtas <mw@...ihalf.com>,
Wilson Ding <dingwei@...vell.com>,
Shadi Ammouri <shadi@...vell.com>
Subject: Re: [PATCH 10/10] clk: mvebu: Add the peripheral clock driver for Armada 3700
Hi Stephen,
On jeu., juin 30 2016, Stephen Boyd <sboyd@...eaurora.org> wrote:
>> +
>> + spin_lock_init(&driver_data->lock);
>> +
>> + for (i = 0; i < num_periph; i++) {
>> + struct clk *clk = driver_data->clk_data.clks[i];
>> +
>> + if (armada_3700_add_composite_clk(&data[i], parent_name, reg,
>> + &driver_data->lock, dev, clk))
>> + dev_err(dev, "Can't register periph clock %s\n",
>> + data[i].name);
>> + }
>> +
>> + ret = of_clk_add_provider(np, of_clk_src_onecell_get,
>> + &driver_data->clk_data);
>> + if (ret) {
>> + for (i = 0; i < num_periph; i++)
>> + clk_unregister(driver_data->clk_data.clks[i]);
>
> It would be nice if we had devm_* registration in composite
> clks
>
This comment is the only one I didn't take into account in the second
version I've just sent. I agree it would be nice and I am willing to add
it. However these last days I was very busy with the birth of my last
child: I managed to find time to write this second version in time to be
merged for 4.8 but not enough to add these new function. I will try to
send a patch for it next week.
Thanks for your review,
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
Powered by blists - more mailing lists