lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 07 Jul 2016 09:22:43 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Sanchayan Maity <maitysanchayan@...il.com>
Cc:	shawnguo@...nel.org, stefan@...er.ch, robh+dt@...nel.org,
	srinivas.kandagatla@...aro.org,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 4/5] soc: Add SoC driver for Freescale Vybrid platform

On Thursday, July 7, 2016 12:09:29 PM CEST Sanchayan Maity wrote:
> root@...ibri-vf:/sys/bus/soc/devices/soc0# cat family
> Freescale Vybrid VF610
> root@...ibri-vf:/sys/bus/soc/devices/soc0# cat machine
> Freescale Vybrid
> 

I only have one very high-level comment: I think that "family"
is generally supposed to be the more generic one than "machine",
so maybe swap the contents of the two?

Can you have a look at the other users of soc_device and see how
they handle it? I realize that we are already inconsistent about
how we handle it, just try to make it do what the majority of the
others have.

Aside from that, it all looks reasonable.

	Arnd

Powered by blists - more mailing lists