lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 06 Jul 2016 17:43:11 -0700 From: Michael Turquette <mturquette@...libre.com> To: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>, "Russell King" <linux@...linux.org.uk>, "Rob Herring" <robh@...nel.org>, "Mark Brown" <broonie@...nel.org> Cc: "Linux-Kernel" <linux-kernel@...r.kernel.org>, "Linux-DT" <devicetree@...r.kernel.org>, "Linux-ARM" <linux-arm-kernel@...ts.infradead.org>, "Linux-ALSA" <alsa-devel@...a-project.org>, linux-clk@...r.kernel.org Subject: Re: [PATCH v2] clkdev: add devm_of_clk_get() Quoting Kuninori Morimoto (2016-07-03 18:36:50) > +struct clk *devm_of_clk_get(struct device *dev, > + struct device_node *np, int index) Any reason not to use devm_clk_get? Why do we need this helper? Thanks, Mike > +{ > + struct clk **ptr, *clk; > + > + ptr = devres_alloc(devm_of_clk_release, sizeof(*ptr), GFP_KERNEL); > + if (!ptr) > + return ERR_PTR(-ENOMEM); > + > + clk = of_clk_get(np, index); > + if (!IS_ERR(clk)) { > + *ptr = clk; > + devres_add(dev, ptr); > + } else { > + devres_free(ptr); > + } > + > + return clk; > +} > +EXPORT_SYMBOL(devm_of_clk_get); > + > static struct clk *__of_clk_get_by_name(struct device_node *np, > const char *dev_id, > const char *name) > diff --git a/include/linux/clk.h b/include/linux/clk.h > index a89ba4e..33cd540 100644 > --- a/include/linux/clk.h > +++ b/include/linux/clk.h > @@ -502,6 +502,8 @@ struct of_phandle_args; > > #if defined(CONFIG_OF) && defined(CONFIG_COMMON_CLK) > struct clk *of_clk_get(struct device_node *np, int index); > +struct clk *devm_of_clk_get(struct device *dev, > + struct device_node *np, int index); > struct clk *of_clk_get_by_name(struct device_node *np, const char *name); > struct clk *of_clk_get_from_provider(struct of_phandle_args *clkspec); > #else > @@ -509,6 +511,11 @@ static inline struct clk *of_clk_get(struct device_node *np, int index) > { > return ERR_PTR(-ENOENT); > } > +static inline struct clk *devm_of_clk_get(struct device *dev, > + struct device_node *np, int index) > +{ > + return ERR_PTR(-ENOENT); > +} > static inline struct clk *of_clk_get_by_name(struct device_node *np, > const char *name) > { > -- > 1.9.1 >
Powered by blists - more mailing lists