linux-kernel - Re: [PATCH] kernel/watchdog: use nmi registers snapshot in hardlockup handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Jul 2016 10:30:20 +0200 (CEST)
From:	Jiri Kosina <jikos@...nel.org>
To:	Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Ulrich Obergfell <uobergfe@...hat.com>,
	Aaron Tomlin <atomlin@...hat.com>
Subject: Re: [PATCH] kernel/watchdog: use nmi registers snapshot in hardlockup
 handler

On Tue, 5 Jul 2016, Konstantin Khlebnikov wrote:

> NMI handler doesn't call set_irq_regs(), so get_irq_regs() returns NULL or
> stale snapshot from beginning of IRQ interrupted by NMI. Registers from
> argument are always here and points to interrupted instruction and state.
> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
> Cc: Jiri Kosina <jkosina@...e.cz>

Good catch, thanks for fixing my thinko.

	Reviewed-by: Jiri Kosina <jkosina@...e.cz>

-- 
Jiri Kosina
SUSE Labs