linux-kernel - Re: [PATCH] regmap: add iopoll-like polling macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Jul 2016 11:42:54 +0200
From:	Mark Brown <broonie@...nel.org>
To:	Philipp Zabel <p.zabel@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH] regmap: add iopoll-like polling macro

On Wed, Jul 06, 2016 at 04:19:41PM +0200, Philipp Zabel wrote:

> This patch adds a macro regmap_read_poll_timeout that works similar
> to the readx_poll_timeout defined in linux/iopoll.h, except that this
> can also return the error value returned by a failed regmap_read.

Please make this a proper function.

> +		if (sleep_us) \
> +			usleep_range((sleep_us >> 2) + 1, sleep_us); \

Just write / 4 rather than a shift, the compiler should do the right
thing and it's easier for readers.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)