linux-kernel - Re: [PATCH] xen-blkfront: prefer xenbus_write() over xenbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 07 Jul 2016 04:00:21 -0600
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"Roger Pau Monne" <roger.pau@...rix.com>
Cc:	<xen-devel@...ts.xenproject.org>,
	"Konrad Rzeszutek Wilk" <konrad.wilk@...cle.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xen-blkfront: prefer xenbus_write() over
 xenbus_printf() where possible

>>> On 07.07.16 at 11:44, <roger.pau@...rix.com> wrote:
> On Thu, Jul 07, 2016 at 02:06:33AM -0600, Jan Beulich wrote:
>> ... as being the simpler variant.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@...e.com>
>> ---
>>  drivers/block/xen-blkfront.c |    7 +++----
>>  1 file changed, 3 insertions(+), 4 deletions(-)
>> 
>> --- 4.7-rc6-prefer-xenbus_write.orig/drivers/block/xen-blkfront.c
>> +++ 4.7-rc6-prefer-xenbus_write/drivers/block/xen-blkfront.c
>> @@ -1825,14 +1825,13 @@ again:
>>  		}
>>  		kfree(path);
>>  	}
>> -	err = xenbus_printf(xbt, dev->nodename, "protocol", "%s",
>> -			    XEN_IO_PROTO_ABI_NATIVE);
>> +	err = xenbus_write(xbt, dev->nodename, "protocol",
>> +			   XEN_IO_PROTO_ABI_NATIVE);
>>  	if (err) {
>>  		message = "writing protocol";
>>  		goto abort_transaction;
>>  	}
>> -	err = xenbus_printf(xbt, dev->nodename,
>> -			    "feature-persistent", "%u", 1);
>> +	err = xenbus_printf(xbt, dev->nodename, "feature-persistent", "1");
> 
> AFAICT you forgot to replace xenbus_printf with xenbus_write here.

Oops, indeed - thanks for noticing.

Jan