linux-kernel - Re: [PATCH 2/4] bindings: spi-samsung: add exynos5433 spi compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <577FA1CB.30805@samsung.com>
Date:	Fri, 08 Jul 2016 14:51:23 +0200
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Andi Shyti <andi.shyti@...sung.com>,
	Mark Brown <broonie@...nel.org>
Cc:	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Kukjin Kim <kgene@...nel.org>,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-spi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Andi Shyti <andi@...zian.org>
Subject: Re: [PATCH 2/4] bindings: spi-samsung: add exynos5433 spi compatible

On 07/08/2016 02:18 PM, Andi Shyti wrote:
> The samsung,exynos5433-spi has some peculiarities that bring the
> need of creating a new compatible in the binding.

That is not accurate. This for both: exynos5433 and exynos7.

> 
> One of those is the 3-clocks controller management where the spi
> is fed with three clocks: "spi", "busclkN" and "ioclk".
> 
> Signed-off-by: Andi Shyti <andi.shyti@...sung.com>
> ---
>  Documentation/devicetree/bindings/spi/spi-samsung.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-samsung.txt b/Documentation/devicetree/bindings/spi/spi-samsung.txt
> index 6dbdeb3..d4294c7 100644
> --- a/Documentation/devicetree/bindings/spi/spi-samsung.txt
> +++ b/Documentation/devicetree/bindings/spi/spi-samsung.txt
> @@ -10,6 +10,7 @@ Required SoC Specific Properties:
>      - samsung,s3c6410-spi: for s3c6410 platforms
>      - samsung,s5pv210-spi: for s5pv210 and s5pc110 platforms
>      - samsung,exynos7-spi: for exynos7 platforms
> +    - samsung,exynos5433-spi: for exynos5433 compatible controllers

As I wrote offline, proper order (alpha-numerical), so 5 before 7.

>  
>  - reg: physical base address of the controller and length of memory mapped
>    region.
> 

Thanks for the patch, nice work. I see that you ignored parts of my
offline comments so I guess you leave that work to others (describe
required clock properties, deprecate exynos7-spi). I'll send the follow
up then.

Best regards,
Krzysztof