linux-kernel - Re: [PATCH 1/4] spi: s3c64xx: rename goto labels to meaningful names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <577FA6D0.2070403@samsung.com>
Date:	Fri, 08 Jul 2016 15:12:48 +0200
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Andi Shyti <andi.shyti@...sung.com>,
	Mark Brown <broonie@...nel.org>
Cc:	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Kukjin Kim <kgene@...nel.org>,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-spi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Andi Shyti <andi@...zian.org>
Subject: Re: [PATCH 1/4] spi: s3c64xx: rename goto labels to meaningful names

On 07/08/2016 03:11 PM, Krzysztof Kozlowski wrote:
> On 07/08/2016 02:18 PM, Andi Shyti wrote:
>> In goto labels of the style of
> 
> s/In/The/
> 
>>
>>   err4:
>>   err3:
>>   err2:
>>   err1:
>>
>> is complex to insert in between new errors without renaming all
> 
> s/is/are/ (or just rewrite it... "The style of such goto labels... is")
> 
>> the goto statments. Replace the errX naming style to meaningful
> 
> s/statments/satements/

Yeah, nice job (to me)... error in error correction. Of course
"statements"...

BR,
Krzysztof