linux-kernel - Re: [PATCH] x86/asm/entry: Make thunk's restore a local label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160708133851.GA6864@gmail.com>
Date:	Fri, 8 Jul 2016 15:38:51 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Borislav Petkov <bp@...en8.de>
Cc:	X86 ML <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/asm/entry: Make thunk's restore a local label


* Borislav Petkov <bp@...en8.de> wrote:

> From: Borislav Petkov <bp@...e.de>
> 
> No need to have it appear in objdump output.
> 
> No functionality change.
> 
> Signed-off-by: Borislav Petkov <bp@...e.de>
> ---
>  arch/x86/entry/thunk_64.S | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/entry/thunk_64.S b/arch/x86/entry/thunk_64.S
> index 027aec4a74df..7b506f52a92c 100644
> --- a/arch/x86/entry/thunk_64.S
> +++ b/arch/x86/entry/thunk_64.S
> @@ -33,7 +33,7 @@
>  	.endif
>  
>  	call \func
> -	jmp  restore
> +	jmp  .Lrestore

Btw., could we make it .L_restore to make it more readable - or does the 
underscore confuse tooling?

Thanks,

	Ingo