linux-kernel - RE: [PATCH v4] mwifiex: Reduce endian conversion for REG Host Commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <edd221ee06dd4f9c8ecec45de67de35b@SC-EXCH04.marvell.com>
Date:	Fri, 8 Jul 2016 14:32:31 +0000
From:	Amitkumar Karwar <akarwar@...vell.com>
To:	Kalle Valo <kvalo@...eaurora.org>
CC:	Prasun Maiti <prasunmaiti87@...il.com>,
	Nishant Sarmukadam <nishants@...vell.com>,
	Linux Wireless <linux-wireless@...r.kernel.org>,
	Linux Next <linux-next@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v4] mwifiex: Reduce endian conversion for REG Host
 Commands

> From: linux-wireless-owner@...r.kernel.org [mailto:linux-wireless-
> owner@...r.kernel.org] On Behalf Of Kalle Valo
> Sent: Friday, July 08, 2016 7:10 PM
> To: Amitkumar Karwar
> Cc: Prasun Maiti; Nishant Sarmukadam; Linux Wireless; Linux Next; Linux
> Kernel
> Subject: Re: [PATCH v4] mwifiex: Reduce endian conversion for REG Host
> Commands
> 
> Amitkumar Karwar <akarwar@...vell.com> writes:
> 
> >> From: Prasun Maiti [mailto:prasunmaiti87@...il.com]
> >> Sent: Monday, June 27, 2016 3:43 PM
> >> To: Amitkumar Karwar
> >> Cc: Nishant Sarmukadam; Linux Wireless; Linux Next; Linux Kernel;
> >> Kalle Valo
> >> Subject: [PATCH v4] mwifiex: Reduce endian conversion for REG Host
> >> Commands
> >>
> >> For multiple REG Host Commands (e.g HostCmd_CMD_802_11_EEPROM_ACCESS,
> >> HostCmd_CMD_MAC_REG_ACCESS etc.) "cpu_to_leX"-converted values are
> >> saved to driver. So, "leX_to_cpu" conversion is required too many
> >> times afterwards in driver.
> >>
> >> This patch reduces the endian: conversion without saving "cpu_to_leX"
> >> converted values in driver. This will convert endianness in prepare
> >> command and command response path.
> >>
> >> Signed-off-by: Prasun Maiti <prasunmaiti87@...il.com>
> 
> [deleted almost 300 lines of unnecessary quotes]
> 
> > Any specific reason for dropping this patch?
> > I can see the status as "Deferred" on patchwork.
> 
> It's not dropped, "Deferred" means that the patch was postponed for some
> reason and I need to look at the patch more carefully. In this case I
> did it because I was hoping to see an Acked-by from you.

Thanks for clarification. I will ack the patch.

Regards,
Amitkumar