linux-kernel - Re: [PATCH v14 3/8] perf tests: Add testcase for auxiliary evlist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160708144835.GE31763@krava>
Date:	Fri, 8 Jul 2016 16:48:35 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Wang Nan <wangnan0@...wei.com>
Cc:	acme@...nel.org, lizefan@...wei.com, linux-kernel@...r.kernel.org,
	pi3orama@....com, Arnaldo Carvalho de Melo <acme@...hat.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Nilay Vaish <nilayvaish@...il.com>,
	He Kuang <hekuang@...wei.com>
Subject: Re: [PATCH v14 3/8] perf tests: Add testcase for auxiliary evlist

On Thu, Jul 07, 2016 at 05:34:44AM +0000, Wang Nan wrote:

SNIP

>  }
> diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h
> index 99bcc02..d736cd3 100644
> --- a/tools/perf/util/evlist.h
> +++ b/tools/perf/util/evlist.h
> @@ -149,6 +149,14 @@ union perf_event *perf_evlist__mmap_read_backward(struct perf_evlist *evlist,
>  						  int idx);
>  void perf_evlist__mmap_read_catchup(struct perf_evlist *evlist, int idx);
>  
> +static inline void perf_evlist__mmap_read_catchup_all(struct perf_evlist *evlist)
> +{
> +	int i;
> +
> +	for (i = 0; i < evlist->nr_mmaps; i++)
> +		perf_evlist__mmap_read_catchup(evlist, i);
> +}

any reason for this to be inline and not
static within tests/backward-ring-buffer.c?

thanks,
jirka