lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 08 Jul 2016 10:17:32 -0700 From: Tim Chen <tim.c.chen@...ux.intel.com> To: Herbert Xu <herbert@...dor.apana.org.au> Cc: Ingo Molnar <mingo@...nel.org>, "H. Peter Anvin" <hpa@...or.com>, Dan Carpenter <dan.carpenter@...cle.com>, "David S. Miller" <davem@...emloft.net>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, x86@...nel.org, Megha Dey <megha.dey@...el.com>, "Wang, Rui Y" <rui.y.wang@...el.com>, Denys Vlasenko <dvlasenk@...hat.com>, Xiaodong Liu <xiaodong.liu@...el.com>, linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org, Linus Torvalds <torvalds@...ux-foundation.org>, Andrew Morton <akpm@...ux-foundation.org>, Peter Zijlstra <a.p.zijlstra@...llo.nl> Subject: Re: [patch] crypto: sha256-mb - cleanup a || vs | typo On Sat, 2016-07-09 at 00:45 +0800, Herbert Xu wrote: > On Fri, Jul 08, 2016 at 09:28:03AM -0700, Tim Chen wrote: > > > > > > Sorry I was on vacation and didn't get to respond earlier. > > Let's switch the above from | to || so the code logic is > > clearer. Also clean up various multi-line comment style > > inconsistencies in patch below. > Nack. As I said the commenting style in the crypto API is the > same as the network stack. So unless we decide to change both > please stick to the current style. > Will you like a patch with just the | to || change, or leave the code as is? Tim
Powered by blists - more mailing lists