linux-kernel - Re: [PATCH] clk: clk-conf: Fix error message when clock isn't found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 08 Jul 2016 11:28:14 -0700
From:	Michael Turquette <mturquette@...libre.com>
To:	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	linux-kernel@...r.kernel.org
Cc:	"Tomeu Vizoso" <tomeu.vizoso@...labora.com>,
	"Stephen Boyd" <sboyd@...eaurora.org>, linux-clk@...r.kernel.org
Subject: Re: [PATCH] clk: clk-conf: Fix error message when clock isn't found

Quoting Tomeu Vizoso (2016-07-08 00:14:38)
> When failing to lookup the assigned clock for setting its parents, we
> were previously printing a misleading error message that lead to think
> that it was the parent clock what couldn't be found.
> 
> Change error message to make clear that it's the assigned clock what
> couldn't be found in this case.
> 
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@...labora.com>

Applied.

Regards,
Mike

> ---
>  drivers/clk/clk-conf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clk-conf.c b/drivers/clk/clk-conf.c
> index 43a218f35b19..674785d968a3 100644
> --- a/drivers/clk/clk-conf.c
> +++ b/drivers/clk/clk-conf.c
> @@ -55,7 +55,7 @@ static int __set_clk_parents(struct device_node *node, bool clk_supplier)
>                 }
>                 clk = of_clk_get_from_provider(&clkspec);
>                 if (IS_ERR(clk)) {
> -                       pr_warn("clk: couldn't get parent clock %d for %s\n",
> +                       pr_warn("clk: couldn't get assigned clock %d for %s\n",
>                                 index, node->full_name);
>                         rc = PTR_ERR(clk);
>                         goto err;
> -- 
> 2.5.5
>