linux-kernel - Re: [RFC][PATCH] ftrace/scripts: Work around for addition of metag magic but not relocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160708173237.6a24ef21@gandalf.local.home>
Date:	Fri, 8 Jul 2016 17:32:37 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Laura Abbott <labbott@...hat.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH] ftrace/scripts: Work around for addition of metag
 magic but not relocations

On Fri,  8 Jul 2016 12:18:50 -0700
Laura Abbott <labbott@...hat.com> wrote:

> glibc recently did a sync up (94e73c95d9b5 "elf.h: Sync with the gabi
> webpage") that added a #define for EM_METAG but did not add relocations
> 
> This triggers build errors:
> 
> scripts/recordmcount.c: In function 'do_file':
> scripts/recordmcount.c:466:28: error: 'R_METAG_ADDR32' undeclared (first use in this function)
>   case EM_METAG:  reltype = R_METAG_ADDR32;
>                             ^~~~~~~~~~~~~~
> scripts/recordmcount.c:466:28: note: each undeclared identifier is reported only once for each function it appears in
> scripts/recordmcount.c:468:20: error: 'R_METAG_NONE' undeclared (first use in this function)
>      rel_type_nop = R_METAG_NONE;
>                     ^~~~~~~~~~~~
> 
> Work around this change with some more #ifdefery for the relocations.

Looks fine to me. I'll pull it in, and this probably should go stable
too.

-- Steve

> 
> Signed-off-by: Laura Abbott <labbott@...hat.com>
> ---
> I hit this while testing with a newer glibc. I'm not sure what the policy is
> about glibc, so this might just serve as an FYI for anyone else who
> is working on the bleeding edge.
> 
> Fedora bug is at https://bugzilla.redhat.com/show_bug.cgi?id=1354034 for the
> curious.
> ---