linux-kernel - Re: [tip:x86/debug] printk: Make the printk*once() variants return a value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1468154020.8360.114.camel@perches.com>
Date:	Sun, 10 Jul 2016 05:33:40 -0700
From:	Joe Perches <joe@...ches.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	mingo@...nel.org, luto@...nel.org, hpa@...or.com,
	peterz@...radead.org, brgerst@...il.com,
	torvalds@...ux-foundation.org, tglx@...utronix.de,
	luto@...capital.net, dvlasenk@...hat.com, fweisbec@...il.com,
	jpoimboe@...hat.com, bp@...e.de, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/debug] printk: Make the printk*once() variants return
 a value

On Sun, 2016-07-10 at 14:06 +0200, Borislav Petkov wrote:
> On Sun, Jul 10, 2016 at 01:23:51AM -0700, Joe Perches wrote:
> > 
> > Assuming tip is included in linux-next as of july 8, yes.
> Try one which has http://git.kernel.org/tip/81c2949f7fdcf8ff681326669a
> fde24962232670

That commit isn't in -next and this change to add a return
value to no_printk in _this_ patch is, as I wrote, not
required here.

It's fine that no_printk return a 0 value, but it should
be introduced in a separate patch that introduces that
requirement or at least mentioned in the changelog of
this patch _why_ it's it to be changed.  Otherwise, the
change just appears spurious.