[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20160710151646.GB2512@x1.redhat.com>
Date: Sun, 10 Jul 2016 23:16:46 +0800
From: Baoquan He <bhe@...hat.com>
To: Ingo Molnar <mingo@...nel.org>
Cc: peterz@...radead.org, hpa@...or.com, keescook@...omium.org,
xiaolong.ye@...el.com, linux-kernel@...r.kernel.org,
tglx@...utronix.de, torvalds@...ux-foundation.org,
linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/boot] x86/KASLR: Fix boot crash with certain memory
configurations
On 07/10/16 at 01:24pm, Ingo Molnar wrote:
>
> * Baoquan He <bhe@...hat.com> wrote:
>
> > Hi Ingo,
> >
> > I am sorry the previous post didn't contain formal patch log. I made a new one
> > as below. The boot crash could not only happen with certain memory. Because of
> > this code bug the regions which need be avoided like the zipped kernel with its
> > unzipping running code, initrd, kernel command line could be corrupted if
> > mem_avoid_overlap() can't find the overlap region with the lowest address. But
> > it's very lucky that Xiaolong's system which has only 300M memory can always
> > reproduce it. I checked the boog log and found on his system no any other slot
> > can be chosen except for the original one. If we have a system with large memory
> > it may not be easy to hit it, at least with low probability since there are many
> > candidate slots.
>
> So if it's just a better changelog that what I wrote I wouldn't rebase the commit:
> there's other commits on top of the fix meanwhile. Should a rebase become
> necessary at a later point I'll update it with your extended changelog.
Yes, it's just a changelog update, no need to rebase it now.
Thanks
Baoquan
Powered by blists - more mailing lists