linux-kernel - Re: [PATCH] leds: leds-gpio: Set of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <578356BD.8000309@samsung.com>
Date:	Mon, 11 Jul 2016 10:20:13 +0200
From:	Jacek Anaszewski <j.anaszewski@...sung.com>
To:	Rafał Miłecki <zajec5@...il.com>
Cc:	Richard Purdie <rpurdie@...ys.net>,
	"open list:LED SUBSYSTEM" <linux-leds@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] leds: leds-gpio: Set of_node for created LED devices

On 07/11/2016 09:52 AM, Rafał Miłecki wrote:
> On 07/11/2016 09:34 AM, Jacek Anaszewski wrote:
>> On 07/08/2016 02:53 PM, Rafał Miłecki wrote:
>>> When working with Device Tree we iterate over children of "gpio-leds"
>>> compatible node and create LED device for each of them. We take care of
>>> all common DT properties (label, default trigger, state, etc.), however
>>> some triggers may want to support more of them.
>>>
>>> It could be useful for timer trigger to support setting delay on/off
>>> values with Device Tree property. Or for transient trigger to support
>>> e.g. duration property.
>>>
>>> We obviously should handle such properties in triggers, not in generic
>>> code. To let trigger drivers read properties from DT node we need to set
>>> of_node to point the relevant node. This change allows using all kind of
>>> of helpers in e.g. "activate" callbacks.
>>>
>>> Signed-off-by: Rafał Miłecki <zajec5@...il.com>
>>> ---
>>>   drivers/leds/leds-gpio.c | 5 +++--
>>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
>>> index 8229f06..9b991d4 100644
>>> --- a/drivers/leds/leds-gpio.c
>>> +++ b/drivers/leds/leds-gpio.c
>>> @@ -165,6 +165,7 @@ static struct gpio_leds_priv
>>> *gpio_leds_create(struct platform_device *pdev)
>>>           return ERR_PTR(-ENOMEM);
>>>
>>>       device_for_each_child_node(dev, child) {
>>> +        struct gpio_led_data *led_dat = &priv->leds[priv->num_leds];
>>
>> This seems to be an unrelated change.
>
> We already got
> &priv->leds[priv->num_leds]
> and I needed to add
> priv->leds[priv->num_leds].cdev.dev->of_node
>
> I didn't want to duplicate code accessing so deep struct, so I added a
> helper.
>
> Is that a good explanation? Or would you like me to change this code?

Ah, I missed that. Patch applied.

Thanks,
Jacek Anaszewski