linux-kernel - Re: cxl: make base more explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 Jul 2016 20:19:30 +1000 (AEST)
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	<linux-kernel@...r.kernel.org>
Cc:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Michael Neuling <mikey@...ling.org>,
	linuxppc-dev@...ts.ozlabs.org, Ian Munsie <imunsie@....ibm.com>
Subject: Re: cxl: make base more explicitly non-modular

On Sun, 2016-03-07 at 20:31:53 UTC, Paul Gortmaker wrote:
> The Kconfig/Makefile currently controlling compilation of this code is:
> 
> drivers/misc/cxl/Kconfig:config CXL_BASE
> drivers/misc/cxl/Kconfig:       bool
> 
> drivers/misc/cxl/Makefile:obj-$(CONFIG_CXL_BASE)          += base.o
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets convert the one module_init into device_initcall so that
> when reading the driver it more clear that it is builtin-only.
> 
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.
> 
> We don't replace module.h with init.h since the file is doing
> other modular stuff (module_get/put) even though it is built-in.
> 
> Cc: Ian Munsie <imunsie@....ibm.com>
> Cc: Michael Neuling <mikey@...ling.org>
> Cc: linuxppc-dev@...ts.ozlabs.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> Acked-by: Ian Munsie <imunsie@....ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/e00878be3f414a99234b3c9613

cheers