linux-kernel - Re: [PATCH] ARM: s3c64xx: avoid warning about 'struct device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1807726.lxvlsY5ymW@wuerfel>
Date:	Mon, 11 Jul 2016 13:15:11 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Rob Herring <robh@...nel.org>,
	Kefeng Wang <wangkefeng.wang@...wei.com>,
	Kukjin Kim <kgene@...nel.org>,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node'

On Monday, June 27, 2016 1:33:51 PM CEST Krzysztof Kozlowski wrote:
> On 06/27/2016 01:02 PM, Arnd Bergmann wrote:
> > The change to simplify of_platform_populate() had an unintended
> > side-effect of introducing a build warning on s3c64xx:
> > 
> > In file included from arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c:18:0:
> > arch/arm/mach-s3c64xx/common.h:27:30: error: 'struct device_node' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> > 
> > This adds a forward-declaration for the structure name in the
> > header to avoid the warning.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Fixes: 850bea2335e4 ("arm: Remove unnecessary of_platform_populate with default match table")
> > ---
> > Rob, can you apply this on top of the devicetree git so we don't
> > have to coordinate the merges?
> 
> Acked-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

Hi Rob,

I still get the warning in every linux-next build, do you plan to pick
up the fix for the commit you merged, or should I try to work around it
in arm-soc and leave this as a bisection problem?

	Arnd