linux-kernel - [PATCH] xen_pvscsi: reclaim the ring request when mapping data failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Jul 2016 10:51:26 +0800
From:	Bin Wu <wu.wubin@...wei.com>
To:	<boris.ostrovsky@...cle.com>, <david.vrabel@...rix.com>,
	<jgross@...e.com>, <jejb@...ux.vnet.ibm.com>,
	<martin.petersen@...cle.com>, <xen-devel@...ts.xenproject.org>,
	<linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<wu.wubin@...wei.com>
Subject: [PATCH] xen_pvscsi: reclaim the ring request when mapping data failed

During scsi command queueing, if mapping data fails, we need to
reclaim the failed request. Otherwise, the garbage request will
be pushed into the ring for the backend to work.

Signed-off-by: Bin Wu <wu.wubin@...wei.com>
---
  drivers/scsi/xen-scsifront.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c
index 9dc8687..655163d 100644
--- a/drivers/scsi/xen-scsifront.c
+++ b/drivers/scsi/xen-scsifront.c
@@ -565,6 +565,7 @@ static int scsifront_queuecommand(struct Scsi_Host *shost,
      err = map_data_for_request(info, sc, ring_req, shadow);
      if (err < 0) {
          pr_debug("%s: err %d\n", __func__, err);
+        info->ring.req_prod_pvt--;
          scsifront_put_rqid(info, rqid);
          scsifront_return(info);
          spin_unlock_irqrestore(shost->host_lock, flags);
-- 
2.3.2 (Apple Git-55)