linux-kernel - [PATCH] usb:solve resume usb device identification problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Jul 2016 20:57:03 +0800
From:	Pengcheng Li <lpc.li@...ilicon.com>
To:	<gregkh@...uxfoundation.org>, <stern@...land.harvard.edu>,
	<baolu.lu@...ux.intel.com>, <chasemetzger15@...il.com>,
	<mathias.nyman@...ux.intel.com>, <oneukum@...e.com>,
	<jun.li@...escale.com>
CC:	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Pengcheng Li <lpc.li@...ilicon.com>
Subject: [PATCH] usb:solve resume usb device identification problem

A usb device in the connection state. Then host is suspend and resume.
But the usb device could not be at the right speed. We should be reset
the reset.

Signed-off-by: Pengcheng Li <lpc.li@...ilicon.com>
---
 drivers/usb/core/hub.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index bee1351..cd71bb3 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -3455,7 +3455,7 @@ int usb_port_resume(struct usb_device *udev, pm_message_t msg)
 	struct usb_hub	*hub = usb_hub_to_struct_hub(udev->parent);
 	struct usb_port *port_dev = hub->ports[udev->portnum  - 1];
 	int		port1 = udev->portnum;
-	int		status;
+	int		status, retval;
 	u16		portchange, portstatus;
 
 	if (!test_and_set_bit(port1, hub->child_usage_bits)) {
@@ -3512,6 +3512,10 @@ int usb_port_resume(struct usb_device *udev, pm_message_t msg)
 		}
 	}
 
+	retval = hub_port_reset(hub, port1, udev, HUB_ROOT_RESET_TIME, false);
+	if (retval < 0)
+		hub_port_disable(hub, port1, 0);
+
 	if (udev->persist_enabled)
 		status = wait_for_connected(udev, hub, &port1, &portchange,
 				&portstatus);
-- 
2.8.2