linux-kernel - Re: [PATCH 3/3] Documentation: mmc: add description for new no-sd* and no-mmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160711135735.GA18339@rob-hp-laptop>
Date:	Mon, 11 Jul 2016 08:57:35 -0500
From:	Rob Herring <robh@...nel.org>
To:	Shawn Lin <shawn.lin@...k-chips.com>
Cc:	Ulf Hansson <ulf.hansson@...aro.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Jaehoon Chung <jh80.chung@...sung.com>,
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
	Doug Anderson <dianders@...omium.org>,
	devicetree@...r.kernel.org
Subject: Re: [PATCH 3/3] Documentation: mmc: add description for new no-sd*
 and no-mmc

On Fri, Jul 01, 2016 at 03:45:30PM +0800, Shawn Lin wrote:
> This patch adds description for no-sd, no-sdio, no-mmc. We
> expect the specific boards adds these in DT to improve
> the initialization. For instance, for a soldered eMMC slot,
> we could skip sending SDIO and SD commands to probe its card
> types as it's always should be the type fo MMC card.
> 
> Signed-off-by: Shawn Lin <shawn.lin@...k-chips.com>
> ---
> 
>  Documentation/devicetree/bindings/mmc/mmc.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt
> index ecc007a..b2046c6 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc.txt
> +++ b/Documentation/devicetree/bindings/mmc/mmc.txt
> @@ -49,6 +49,9 @@ Optional properties:
>  - mmc-hs400-enhanced-strobe: eMMC HS400 enhanced strobe mode is supported
>  - dsr: Value the card's (optional) Driver Stage Register (DSR) should be
>    programmed with. Valid range: [0 .. 0xffff].
> +- no-sdio: skip sending sdio cmd during initialization
> +- no-sd: skip sending sd cmd during initialization
> +- no-mmc: skip sending mmc cmd during initialization

I still have issue with the description for these properties and the 
commit msg. They are fine if described as controller limitations as Ulf 
described. If folks want to (ab)use the properties for just skipping 
init, then that's their problem.

Rob