linux-kernel - Re: [PATCH v14 3/8] perf tests: Add testcase for auxiliary evlist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 Jul 2016 11:20:03 +0800
From:	"Wangnan (F)" <wangnan0@...wei.com>
To:	Jiri Olsa <jolsa@...hat.com>
CC:	<acme@...nel.org>, <lizefan@...wei.com>,
	<linux-kernel@...r.kernel.org>, <pi3orama@....com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Nilay Vaish <nilayvaish@...il.com>,
	He Kuang <hekuang@...wei.com>
Subject: Re: [PATCH v14 3/8] perf tests: Add testcase for auxiliary evlist



On 2016/7/8 22:48, Jiri Olsa wrote:
> On Thu, Jul 07, 2016 at 05:34:44AM +0000, Wang Nan wrote:
>
> SNIP
>
>>   	ret = TEST_FAIL;
>> -	err = do_test(evlist, opts.mmap_pages, &sample_count,
>> +	err = do_test(evlist, aux_evlist, opts.mmap_pages,
>> +		      &enter_sample_count, &exit_sample_count,
>>   		      &comm_count);
>>   	if (err != TEST_OK)
>>   		goto out_delete_evlist;
>>   
>> -	if ((sample_count != NR_ITERS) || (comm_count != NR_ITERS)) {
>> -		pr_err("Unexpected counter: sample_count=%d, comm_count=%d\n",
>> -		       sample_count, comm_count);
>> +	if (enter_sample_count != exit_sample_count) {
>> +		pr_err("Unexpected counter: enter_sample_count=%d, exit_sample_count=%d\n",
>> +		       enter_sample_count, exit_sample_count);
>> +		goto out_delete_evlist;
>> +	}
>> +
>> +	if ((exit_sample_count != NR_ITERS) || (comm_count != NR_ITERS)) {
>> +		pr_err("Unexpected counter: exit_sample_count=%d, comm_count=%d\n",
>> +		       exit_sample_count, comm_count);
>>   		goto out_delete_evlist;
>>   	}
>>   
>> -	err = do_test(evlist, 1, &sample_count, &comm_count);
>> +	err = do_test(evlist, aux_evlist, 1, &dummy, &dummy, &dummy);
> why dont you test numbers for 1 page mmap?  seems like the data would fit..
> is the purpose just to check if we can map just 1 page?

Data won't fit. 1 page map make sure the buffer is overwritten.

Thank you.

> thanks,
> jirka