linux-kernel - Re: [patch 02/66] irqchip/gic: Convert to hotplug state machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160711143424.GA20760@gmail.com>
Date:	Mon, 11 Jul 2016 16:34:24 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Anna-Maria Gleixner <anna-maria@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Richard Cochran <rcochran@...utronix.de>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Jason Cooper <jason@...edaemon.net>,
	Marc Zyngier <marc.zyngier@....com>
Subject: Re: [patch 02/66] irqchip/gic: Convert to hotplug state machine


* Anna-Maria Gleixner <anna-maria@...utronix.de> wrote:

> More or less straightforward, although this driver sports some very
> interesting SMP setup code. Regarding the callback ordering, this
> deleted comment is interesting:
> 
>    ... the GIC needs to be up before the ARM generic timers.
> 
> That comment is half baken as the same requirement is true for perf.
> 
> Signed-off-by: Richard Cochran <rcochran@...utronix.de>
> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> Cc: Jason Cooper <jason@...edaemon.net>
> Cc: Marc Zyngier <marc.zyngier@....com>
> Signed-off-by: Anna-Maria Gleixner <anna-maria@...utronix.de>

The SOB sequence is unusal. Is this patch missing this line:

  From: Richard Cochran <rcochran@...utronix.de>

... or should the SOB be:

  Acked-by: Richard Cochran <rcochran@...utronix.de>

?

Thanks,

	Ingo