linux-kernel - Re: [PATCH] mtd: nand: brcmnand: Change BUG_ON in brcmnand_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKekbesHHqEgL6ZRCT-PytmbN-iPzhRm723Y8ao0+ggqDbQGtg@mail.gmail.com>
Date:	Mon, 11 Jul 2016 11:32:13 -0400
From:	Kamal Dasu <kamal.dasu@...adcom.com>
To:	Brian Norris <computersforpeace@...il.com>
Cc:	Florian Fainelli <f.fainelli@...il.com>,
	linux-mtd@...ts.infradead.org, Kamal Dasu <kdasu.kdev@...il.com>,
	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	Richard Weinberger <richard@....at>,
	David Woodhouse <dwmw2@...radead.org>,
	"open list:BROADCOM STB NAND FLASH DRIVER" 
	<bcm-kernel-feedback-list@...adcom.com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: nand: brcmnand: Change BUG_ON in brcmnand_send_cmd

On Sat, Jul 9, 2016 at 9:30 PM, Brian Norris
<computersforpeace@...il.com> wrote:
> On Fri, Jul 08, 2016 at 10:36:39AM -0700, Florian Fainelli wrote:
>> Change the BUG_ON() condition in brcmnand_send_cmd() which checks for
>> the interrupt status "controller ready" bit to a WARN_ON.
>>
>> There is no good reason to kill the system when this condition occur
>> because we could have systems which listed the NAND controller as
>> available (e.g: from Device Tree), but the NAND chip could be
>> malfunctioning and not responding.
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
>
> Acked-by: Brian Norris <computersforpeace@...il.com>
>

Reviewed-by: Kamal Dasu <kdasu.kdev@...il.com>

>> ---
>> Note that I even hesitated to remove that completely, but there is
>> some value in knowing about this condition since it helps figuring
>> out what could be wrong.
>>
>>  drivers/mtd/nand/brcmnand/brcmnand.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c
>> index b6062a2f3dfd..72bdc283778d 100644
>> --- a/drivers/mtd/nand/brcmnand/brcmnand.c
>> +++ b/drivers/mtd/nand/brcmnand/brcmnand.c
>> @@ -1165,7 +1165,7 @@ static void brcmnand_send_cmd(struct brcmnand_host *host, int cmd)
>>       ctrl->cmd_pending = cmd;
>>
>>       intfc = brcmnand_read_reg(ctrl, BRCMNAND_INTFC_STATUS);
>> -     BUG_ON(!(intfc & INTFC_CTLR_READY));
>> +     WARN_ON(!(intfc & INTFC_CTLR_READY));
>>
>>       mb(); /* flush previous writes */
>>       brcmnand_write_reg(ctrl, BRCMNAND_CMD_START,
>> --
>> 2.7.4
>>



-- 
Kamal Dasu
Principal Engineer | Broadcom Ltd. 200 Brickstone Sq Andover | 978-719-1405