linux-kernel - Re: [PATCH 2/2] bus: mvebu-mbus: make mvebu_mbus_syscore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87inwctba6.fsf@free-electrons.com>
Date:	Mon, 11 Jul 2016 18:00:33 +0200
From:	Gregory CLEMENT <gregory.clement@...e-electrons.com>
To:	Ben Dooks <ben.dooks@...ethink.co.uk>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Arnd Bergmann <arnd@...db.de>,
	linux-kernel@...ts.codethink.co.uk, Andrew Lunn <andrew@...n.ch>,
	Jason Cooper <jason@...edaemon.net>,
	linux-kernel@...r.kernel.org, Evan Wang <xswang@...vell.com>
Subject: Re: [PATCH 2/2] bus: mvebu-mbus: make mvebu_mbus_syscore_ops static

Hi Ben,
 
 On mar., juin 21 2016, Arnd Bergmann <arnd@...db.de> wrote:

> On Tuesday, June 21, 2016 4:16:19 PM CEST Ben Dooks wrote:
>> 
>> -struct syscore_ops mvebu_mbus_syscore_ops = {
>> +static struct syscore_ops mvebu_mbus_syscore_ops = {
>>         .suspend        = mvebu_mbus_suspend,
>>         .resume         = mvebu_mbus_resume,
>>  };
>> 
>
>
> Looks good, but I immediately thought it should be "const" as well.
> Unfortunately there is a list_head in them, so that isn't easy,
> but if anyone has an idea for how to make these all const, that
> would be nice.
>
> Anyway, that shouldn't stop your patch from getting merged, so
>
> Acked-by: Arnd Bergmann <arnd@...db.de>
>
> (also for patch 1/2).

So I applied both patch in mvebu/cleanup

Thanks,

Gregory

>
> 	Arnd

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com