linux-kernel - Re: [PATCH 1/2] mfd: cros_ec: Add MKBP event support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160711163936.GC1611@dell>
Date:	Mon, 11 Jul 2016 17:39:36 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Olof Johansson <olof@...om.net>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Enric Balletbo i Serra <enric.balletbo@...labora.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	Vic Yang <victoryang@...gle.com>,
	Gwendal Grignou <gwendal@...omium.org>,
	Brian Norris <briannorris@...omium.org>,
	Randall Spangler <rspangler@...omium.org>,
	Vincent Palatin <vpalatin@...omium.org>,
	Benson Leung <bleung@...omium.org>
Subject: Re: [PATCH 1/2] mfd: cros_ec: Add MKBP event support

On Mon, 11 Jul 2016, Lee Jones wrote:

> On Tue, 05 Jul 2016, Olof Johansson wrote:
> 
> > On Tue, Jul 5, 2016 at 2:00 PM, Dmitry Torokhov
> > <dmitry.torokhov@...il.com> wrote:
> > > On July 5, 2016 1:55:44 PM PDT, Olof Johansson <olof@...om.net> wrote:
> > >>On Tue, Jul 5, 2016 at 1:54 PM, Olof Johansson <olof@...om.net> wrote:
> > >>> On Fri, Jul 1, 2016 at 2:07 AM, Enric Balletbo i Serra
> > >>> <enric.balletbo@...labora.com> wrote:
> > >>>> From: Vic Yang <victoryang@...gle.com>
> > >>>>
> > >>>> Newer revisions of the ChromeOS EC add more events besides the
> > >>keyboard
> > >>>> ones. So handle interrupts in the MFD driver and let consumers
> > >>register
> > >>>> for notifications for the events they might care.
> > >>>>
> > >>>> To keep backward compatibility, if the EC doesn't support MKBP
> > >>event, we
> > >>>> fall back to the old MKBP key matrix host command.
> > >>>>
> > >>>> Signed-off-by: Vic Yang <victoryang@...gle.com>
> > >>>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@...labora.com>
> > >>>> Tested-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> > >>>> Cc: Randall Spangler <rspangler@...omium.org>
> > >>>> Cc: Vincent Palatin <vpalatin@...omium.org>
> > >>>> Cc: Benson Leung <bleung@...omium.org>
> > >>>
> > >>> Probably easiest to merge this through the MFD tree due to the
> > >>> overlaps, so for that purpose:
> > >>>
> > >>> Acked-by: Olof Johansson <olof@...om.net>
> > >>
> > >>Argh, I just noticed that the second patch is an input patch, not
> > >>another MFD patch. Either way, I'm OK with this going through the
> > >>input tree if that's easiest. If so, you should probably wait for an
> > >>ack from Lee as well.
> > >
> > > Hmm, I thought I already acked input portion to go through MFD tree... or am I confusing this with some other patch?
> > 
> > Oh, then we're all set. That patch didn't thread with this one in my
> > mailbox so I didn't see the comment thread on it.
>  
> Yes, same for me.
> 
> > Lee, all yours.
> 
> Err, nice, ta!  =;-)
> 
> Eric,
> 
> Please resubmit this set 'threaded' so I might take proper care of
> it.

Wait!  Ignore that.  I got mixed up with what Olof said and the way
things looked in my inbox.  The two patches are in fact threaded.
I'll look to see to them later in the week.  Please bear with me.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog