linux-kernel - Re: [PATCH] spi: spi-ti-qspi: clear wlen field while setting word length.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5783297C.7080702@ti.com>
Date:	Mon, 11 Jul 2016 10:37:08 +0530
From:	Vignesh R <vigneshr@...com>
To:	Prahlad V <prahlad.eee@...il.com>,
	"broonie@...nel.org" <broonie@...nel.org>
CC:	"linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] spi: spi-ti-qspi: clear wlen field while setting word
 length.

Hi Prahlad,

On Sunday 10 July 2016 01:35 AM, Prahlad V wrote:
> When a word length of 1 byte is selected and writing data of length
> more than QSPI_WLEN_MAX_BYTES, first MAX_BYTES will be transfered
> and remaining will be transfered byte by byte. In that case wlen
> field should be cleared before setting.
> 
> Signed-off-by: Prahlad V <prahlad.eee@...il.com>
> ---
>  drivers/spi/spi-ti-qspi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
> index 29ea8d2..6c61f54 100644
> --- a/drivers/spi/spi-ti-qspi.c
> +++ b/drivers/spi/spi-ti-qspi.c
> @@ -276,9 +276,9 @@ static int qspi_write_msg(struct ti_qspi *qspi, struct spi_transfer *t,
>  				cmd |= QSPI_WLEN(QSPI_WLEN_MAX_BITS);
>  			} else {
>  				writeb(*txbuf, qspi->base + QSPI_SPI_DATA_REG);
> -				cmd = qspi->cmd | QSPI_WR_SNGL;

qspi->cmd always has WLEN field cleared and set to WLEN = 1 byte (see
ti_qspi_start_transfer_one()). And hence variable 'cmd' will also have
WLEN set to 1 byte.

>  				xfer_len = wlen;
> -				cmd |= QSPI_WLEN(wlen);
> +				cmd = ((qspi->cmd & ~QSPI_WLEN_MASK) |
> +					     QSPI_WLEN(wlen));

So, this won't be necessary.

-- 
Regards
Vignesh