linux-kernel - Re: [PATCH 1/2] clk: sunxi-ng: h3: Fix audio clock divider offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Jul 2016 14:36:34 -0700
From:	Michael Turquette <mturquette@...libre.com>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	"Stephen Boyd" <sboyd@...eaurora.org>,
	"Chen-Yu Tsai" <wens@...e.org>
Cc:	linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	"Maxime Ripard" <maxime.ripard@...e-electrons.com>
Subject: Re: [PATCH 1/2] clk: sunxi-ng: h3: Fix audio clock divider offset

Quoting Maxime Ripard (2016-07-11 13:34:47)
> The code had a typo and got the wrong offset for the hardcoded divider, fix
> that.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> Reported-by: Jean-Francois Moine <moinejf@...e.fr>
> Reported-by: Chen-Yu Tsai <wens@...e.org>

Applied.

Regards,
Mike

> ---
>  drivers/clk/sunxi-ng/ccu-sun8i-h3.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-h3.c b/drivers/clk/sunxi-ng/ccu-sun8i-h3.c
> index bcc0a95549d3..9af359544110 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun8i-h3.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun8i-h3.c
> @@ -817,8 +817,8 @@ static void __init sun8i_h3_ccu_setup(struct device_node *node)
>  
>         /* Force the PLL-Audio-1x divider to 4 */
>         val = readl(reg + SUN8I_H3_PLL_AUDIO_REG);
> -       val &= ~GENMASK(4, 0);
> -       writel(val | 3, reg + SUN8I_H3_PLL_AUDIO_REG);
> +       val &= ~GENMASK(19, 16);
> +       writel(val | (3 << 16), reg + SUN8I_H3_PLL_AUDIO_REG);
>  
>         sunxi_ccu_probe(node, reg, &sun8i_h3_ccu_desc);
>  }
> -- 
> 2.9.0
>