linux-kernel - Re: [PATCH v2 10/22] usb: chipidea: Add support for ULPI PHY bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Jul 2016 15:02:16 -0700
From:	Stephen Boyd <stephen.boyd@...aro.org>
To:	Peter Chen <hzpeterchen@...il.com>
Cc:	linux-usb@...r.kernel.org,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-arm-msm@...r.kernel.org, Andy Gross <andy.gross@...aro.org>,
	Bjorn Andersson <bjorn.andersson@...aro.org>,
	Neil Armstrong <narmstrong@...libre.com>,
	Arnd Bergmann <arnd@...db.de>, Felipe Balbi <balbi@...nel.org>,
	Peter Chen <peter.chen@....com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Subject: Re: [PATCH v2 10/22] usb: chipidea: Add support for ULPI PHY bus

On 10 July 2016 at 20:10, Peter Chen <hzpeterchen@...il.com> wrote:
> On Thu, Jul 07, 2016 at 03:21:01PM -0700, Stephen Boyd wrote:
>> @@ -418,6 +427,17 @@ static inline bool ci_otg_is_fsm_mode(struct ci_hdrc *ci)
>>  #endif
>>  }
>>
>> +#if IS_ENABLED(CONFIG_USB_CHIPIDEA_ULPI)
>> +int ci_ulpi_init(struct ci_hdrc *ci);
>> +void ci_ulpi_exit(struct ci_hdrc *ci);
>> +int ci_ulpi_resume(struct ci_hdrc *ci);
>> +#else
>> +static inline int ci_ulpi_init(struct ci_hdrc *ci) { return 0; }
>> +static inline void ci_ulpi_exit(struct ci_hdrc *ci) { }
>> +static inline int ci_ulpi_resume(struct ci_hdrc *ci) { return 0; }
>> +#endif
>> +
>> +
>
> One more blank line
>

Fixed.

>> @@ -911,11 +918,15 @@ static int ci_hdrc_probe(struct platform_device *pdev)
>>
>>               /* if both generic PHY and USB PHY layers aren't enabled */
>>               if (PTR_ERR(ci->phy) == -ENOSYS &&
>> -                             PTR_ERR(ci->usb_phy) == -ENXIO)
>> -                     return -ENXIO;
>> +                             PTR_ERR(ci->usb_phy) == -ENXIO) {
>> +                     ret = -ENXIO;
>> +                     goto ulpi_exit;
>> +             }
>>
>> -             if (IS_ERR(ci->phy) && IS_ERR(ci->usb_phy))
>> -                     return -EPROBE_DEFER;
>> +             if (IS_ERR(ci->phy) && IS_ERR(ci->usb_phy)) {
>> +                     ret = -EPROBE_DEFER;
>> +                     goto ulpi_exit;
>> +             }
>
> Just confirm, you try to get PHY through:
>         ci->phy = devm_phy_get(dev->parent, "usb-phy");
> right?

Yes.