linux-kernel - Re: [PATCH v6] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 Jul 2016 14:20:01 +0800
From:	Xing Zheng <zhengxing@...k-chips.com>
To:	Rob Herring <robh@...nel.org>
Cc:	linux-rockchip@...ts.infradead.org, dianders@...omium.org,
	heiko@...ech.de, smbarber@...gle.com,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org
Subject: Re: [PATCH v6] ASoC: rockchip: Add machine driver for RK3399 GRU
 Boards

Hi Mark,
     In your opinion, is there anything needs to be optimized in this patch?

Thanks.

On 2016年06月20日 21:08, Rob Herring wrote:
> On Thu, Jun 16, 2016 at 08:40:58PM +0800, Xing Zheng wrote:
>> Because we need to support the multiple codecs (MAX98357A/RT5514/DA7219)
>> on the RK3399 GRU boards, this patch can help us to support these codecs.
>>
>> Signed-off-by: Xing Zheng <zhengxing@...k-chips.com>
>> ---
>>
>> Changes in v6:
>> - remove enable/disable dapm pins, and to switch codecs via user space
>> - fix "Speaker" dapm route for max98357a
>> - add SND_JACK_LINEOUT flag for da7219 jack detection
>>
>> Changes in v5:
>> - fix the build warning for missing I2C/CLKDEV_LOOKUP dependency
>>
>> Changes in v4:
>> - the compatible name needs to be based on a single reference design,
>>    and the name of the board is called "GRU"
>> - use one i2sX card "rockchip,cpu = <&i2s0>" instead of array that is
>>    based on GRU
>> - rename DOC to rockchip,rk3399-gru-sound.txt
>> - rename compatible to rockchip,rk3399-gru-sound
>> - rename source code to rk3399_gru_sound.c
>>
>> Changes in v3:
>> - rename DOC to rockchip,rk3399-max98357a-rt5514-da7219.txt
>> - rename compatible to rockchip,rk3399-max98357a-rt5514-da7219
>> - rename source code to rk3399_max98357a_rt5514_da7219.c
>>
>> Changes in v2:
>> - use the FS 256 to set mclks of the max98357a and rt5514 danamically
>> - add more sample rate for da7219
>>
>>   .../bindings/sound/rockchip,rk3399-gru-sound.txt   |   15 +
> Acked-by: Rob Herring <robh@...nel.org>
>
>>   sound/soc/rockchip/Kconfig                         |   11 +
>>   sound/soc/rockchip/Makefile                        |    2 +
>>   sound/soc/rockchip/rk3399_gru_sound.c              |  322 ++++++++++++++++++++
>>   4 files changed, 350 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt
>>   create mode 100644 sound/soc/rockchip/rk3399_gru_sound.c
>
>

-- 
- Xing Zheng