linux-kernel - Re: [PATCH] drm/vc4: remove redundant ret status check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87zipn1z62.fsf@eliezer.anholt.net>
Date:	Mon, 11 Jul 2016 17:24:21 -0700
From:	Eric Anholt <eric@...olt.net>
To:	Colin King <colin.king@...onical.com>,
	David Airlie <airlied@...ux.ie>,
	dri-devel@...ts.freedesktop.org
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/vc4: remove redundant ret status check

Colin King <colin.king@...onical.com> writes:

> From: Colin Ian King <colin.king@...onical.com>
>
> At the current point where ret is being checked for non-zero it has
> not changed since it was initialized to zero, hence the check and the
> label unref are redundant and can be removed.

Reviewed-by: Eric Anholt <eric@...olt.net>

I'll put this in my next pull request.

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)