linux-kernel - Re: [PATCH 2/3] chcr: Support for Chelsio's Crypto Hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160712083552.GA29994@gondor.apana.org.au>
Date:	Tue, 12 Jul 2016 16:35:52 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Yeshaswi M R Gowda <yeshaswi@...lsio.com>
Cc:	hariprasad@...lsio.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, davem@...emloft.net,
	linux-crypto@...r.kernel.org, jlulla@...lsio.com,
	atul.gupta@...lsio.com, harsh@...lsio.com
Subject: Re: [PATCH 2/3] chcr: Support for Chelsio's Crypto Hardware

On Mon, Jul 11, 2016 at 11:28:07AM -0700, Yeshaswi M R Gowda wrote:
>
> +	u_ctx = ULD_CTX(ctx);
> +	if (cxgb4_is_crypto_q_full(u_ctx->lldi.ports[0], ctx->tx_channel_id))
> +		return -EBUSY;

You cannot just return -EBUSY.  If the request has the MAY_BACKLOG
bit set, it must be queued regardless, but you should return -EBUSY
in order to throttle the user and then call the completion function
with -EINPROGRESS once the queue can accept more requests from the
user.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt