linux-kernel - Re: [PATCH] arm64: Add Broadcom Set Top Box Kconfig entry point

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Jul 2016 10:06:08 +0100
From:	Sudeep Holla <sudeep.holla@....com>
To:	Markus Mayer <mmayer@...adcom.com>
Cc:	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	Sudeep Holla <sudeep.holla@....com>,
	Doug Berger <opendmb@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Florian Fainelli <f.fainelli@...il.com>,
	Broadcom Kernel List <bcm-kernel-feedback-list@...adcom.com>,
	ARM Kernel Mailing List 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] arm64: Add Broadcom Set Top Box Kconfig entry point



On 29/06/16 20:49, Markus Mayer wrote:
> From: Florian Fainelli <f.fainelli@...il.com>
>
> Add an ARCH_BRCMSTB Kconfig symbol which allows us not to update the
> dependencies for all STB-related drivers. Select BRCMSTB_L2_IRQ and
> GENERIC_IRQ_CHIP which are required for proper functioning.
>
> Signed-off-by: Doug Berger <opendmb@...il.com>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> Signed-off-by: Markus Mayer <mmayer@...adcom.com>
> ---
>
>   arch/arm64/Kconfig.platforms | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 7ef1d05..22b5c7f 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -29,6 +29,13 @@ config ARCH_BERLIN
>   	help
>   	  This enables support for Marvell Berlin SoC Family
>
> +config ARCH_BRCMSTB
> +	bool "Broadcom Set-Top-Box SoCs"
> +	select BRCMSTB_L2_IRQ

I see that BRCMSTB_L2_IRQ selects GENERIC_IRQ_CHIP already so the below
one is redundant, generally irqchip code should select GENERIC_IRQ_CHIP

> +	select GENERIC_IRQ_CHIP
> +	help
> +	  This enables support for Broadcom's ARMv8 Set Top Box SoCs
> +
>   config ARCH_EXYNOS
>   	bool "ARMv8 based Samsung Exynos SoC family"
>   	select COMMON_CLK_SAMSUNG
>

-- 
Regards,
Sudeep