linux-kernel - [PATCH] [media] mb86a20s: remove redundant check if val is less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1468315851-9179-1-git-send-email-colin.king@canonical.com>
Date:	Tue, 12 Jul 2016 10:30:51 +0100
From:	Colin King <colin.king@...onical.com>
To:	Mauro Carvalho Chehab <mchehab@...nel.org>,
	linux-media@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] [media] mb86a20s: remove redundant check if val is less than zero

From: Colin Ian King <colin.king@...onical.com>

The result of mb86a20s_readreg(state, 0x0a) & 0xf is always in the range
0x00 to 0x0f and can never be negative, so remove the redundant check
of the result being less than zero.

Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 drivers/media/dvb-frontends/mb86a20s.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/media/dvb-frontends/mb86a20s.c b/drivers/media/dvb-frontends/mb86a20s.c
index fb88ddd..0205846 100644
--- a/drivers/media/dvb-frontends/mb86a20s.c
+++ b/drivers/media/dvb-frontends/mb86a20s.c
@@ -302,8 +302,6 @@ static int mb86a20s_read_status(struct dvb_frontend *fe, enum fe_status *status)
 	*status = 0;
 
 	val = mb86a20s_readreg(state, 0x0a) & 0xf;
-	if (val < 0)
-		return val;
 
 	if (val >= 2)
 		*status |= FE_HAS_SIGNAL;
-- 
2.8.1