linux-kernel - Re: [PATCH] ALSA: ak4114: remove redundant check on err being

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h37nfrvut.wl-tiwai@suse.de>
Date:	Tue, 12 Jul 2016 12:31:22 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	"Colin King" <colin.king@...onical.com>
Cc:	<alsa-devel@...a-project.org>, "Jaroslav Kysela" <perex@...ex.cz>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: ak4114: remove redundant check on err being < 0

On Tue, 12 Jul 2016 12:26:29 +0200,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> snd_ak4114_create checks if the error return err is less than zero
> or not.  This is a redundant check, err can only be < 0 to get to
> the __fail label, in which case just return err and remove the
> redundant check (since we never return -EIO).
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks.


Takashi