| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 12 Jul 2016 14:11:23 +0200
From: Daniel Vetter <daniel@...ll.ch>
To: Alexey Khoroshilov <khoroshilov@...ras.ru>
Cc: David Airlie <airlied@...ux.ie>, ldv-project@...uxtesting.org,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm_aux-dev: fix error handling in drm_dp_aux_dev_init()
On Thu, Jun 30, 2016 at 12:52:15AM +0300, Alexey Khoroshilov wrote:
> If class_create() fails, there is no need for class_destroy().
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>
Applied to drm-misc, thanks for the patch. Out of curiosity, how exactly
did you spot this bug?
-Daniel
> ---
> drivers/gpu/drm/drm_dp_aux_dev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_aux_dev.c b/drivers/gpu/drm/drm_dp_aux_dev.c
> index 3334baacf43d..734f86a345f6 100644
> --- a/drivers/gpu/drm/drm_dp_aux_dev.c
> +++ b/drivers/gpu/drm/drm_dp_aux_dev.c
> @@ -355,8 +355,7 @@ int drm_dp_aux_dev_init(void)
>
> drm_dp_aux_dev_class = class_create(THIS_MODULE, "drm_dp_aux_dev");
> if (IS_ERR(drm_dp_aux_dev_class)) {
> - res = PTR_ERR(drm_dp_aux_dev_class);
> - goto out;
> + return PTR_ERR(drm_dp_aux_dev_class);
> }
> drm_dp_aux_dev_class->dev_groups = drm_dp_aux_groups;
>
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Powered by blists - more mailing lists