linux-kernel - Re: [PATCH 5/7] gpu: drm: sti_vtg: add missing of_node_put after calling of_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+M3ks7=hqGkfxB0Erq8trPmayiiENOZOUvYJULsx_mhAdyq6g@mail.gmail.com>
Date:	Tue, 12 Jul 2016 14:59:59 +0200
From:	Benjamin Gaignard <benjamin.gaignard@...aro.org>
To:	Peter Chen <peter.chen@....com>
Cc:	David Airlie <airlied@...ux.ie>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Vincent Abriou <vincent.abriou@...com>
Subject: Re: [PATCH 5/7] gpu: drm: sti_vtg: add missing of_node_put after
 calling of_parse_phandle

Acked-by: Benjamin Gaignard <benjamin.gaignard@...aro.org>

2016-07-05 4:04 GMT+02:00 Peter Chen <peter.chen@....com>:
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Cc: Benjamin Gaignard <benjamin.gaignard@...aro.org>
> Cc: Vincent Abriou <vincent.abriou@...com>
> Signed-off-by: Peter Chen <peter.chen@....com>
> ---
>  drivers/gpu/drm/sti/sti_vtg.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c
> index 6bf4ce4..0100c7c 100644
> --- a/drivers/gpu/drm/sti/sti_vtg.c
> +++ b/drivers/gpu/drm/sti/sti_vtg.c
> @@ -432,6 +432,7 @@ static int vtg_probe(struct platform_device *pdev)
>         np = of_parse_phandle(pdev->dev.of_node, "st,slave", 0);
>         if (np) {
>                 vtg->slave = of_vtg_find(np);
> +               of_node_put(np);
>
>                 if (!vtg->slave)
>                         return -EPROBE_DEFER;
> --
> 1.9.1
>



-- 
Benjamin Gaignard

Graphic Working Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog