linux-kernel - Re: [PATCH v2] relay: Add global mode support for buffer-only channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160712130100.GT6157@nuc-i3427.alporthouse.com>
Date:	Tue, 12 Jul 2016 14:01:00 +0100
From:	Chris Wilson <chris@...is-wilson.co.uk>
To:	"Goel, Akash" <akash.goel@...el.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk,
	Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>,
	Tom Zanussi <tzanussi@...il.com>
Subject: Re: [PATCH v2] relay: Add global mode support for buffer-only
 channels

On Tue, Jul 12, 2016 at 06:20:06PM +0530, Goel, Akash wrote:
> Thanks much, will update the documentation as well as the changelog
> as per the above.
> 
> But an export of symbol relay_late_setup_files() is still needed, just
> like relay_open() is exported, in order to make it accessible to
> modules like i915 ?

Yes, we need the companion function in i915.ko. That needs to be
explained in the patch notes to justify adding the EXPORT_SYMBOL.
Otherwise without that context, it looks unnecessary as Andrew objected
to.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre