linux-kernel - [PATCH] kasan: use \n with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1468333008-21930-1-git-send-email-vegard.nossum@oracle.com>
Date:	Tue, 12 Jul 2016 16:16:48 +0200
From:	Vegard Nossum <vegard.nossum@...cle.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	linux-kernel@...r.kernel.org,
	Vegard Nossum <vegard.nossum@...cle.com>,
	Andrey Ryabinin <aryabinin@...tuozzo.com>
Subject: [PATCH] kasan: use \n with pr_emerg

I'm seeing this in the kernel log:

    kasan: CONFIG_KASAN_INLINE enabled
    kasan: GPF could be caused by NULL-ptr deref or user memory accessgeneral protection fault: 0000 [#1] KASAN
    CPU: 0 PID: 56 Comm: ext4.exe Not tainted 4.7.0-rc6 #1

We really ought to be using \n with pr_*() so the 'general protection
fault...' starts on a line of its own. With this patch it looks better:

    kasan: CONFIG_KASAN_INLINE enabled
    kasan: GPF could be caused by NULL-ptr deref or user memory access
    general protection fault: 0000 [#1] KASAN
    CPU: 0 PID: 56 Comm: ext4.exe Not tainted 4.7.0-rc7+ #650

Cc: Andrey Ryabinin <aryabinin@...tuozzo.com>
Signed-off-by: Vegard Nossum <vegard.nossum@...cle.com>
---
 arch/x86/mm/kasan_init_64.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/mm/kasan_init_64.c b/arch/x86/mm/kasan_init_64.c
index 1b1110f..0493c17 100644
--- a/arch/x86/mm/kasan_init_64.c
+++ b/arch/x86/mm/kasan_init_64.c
@@ -54,8 +54,8 @@ static int kasan_die_handler(struct notifier_block *self,
 			     void *data)
 {
 	if (val == DIE_GPF) {
-		pr_emerg("CONFIG_KASAN_INLINE enabled");
-		pr_emerg("GPF could be caused by NULL-ptr deref or user memory access");
+		pr_emerg("CONFIG_KASAN_INLINE enabled\n");
+		pr_emerg("GPF could be caused by NULL-ptr deref or user memory access\n");
 	}
 	return NOTIFY_OK;
 }
-- 
1.9.1