linux-kernel - Re: [PATCH -next] nvme-rdma: fix the return value of nvme_rdma_reinit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1468333123.6604.2.camel@linux.intel.com>
Date:	Tue, 12 Jul 2016 07:18:43 -0700
From:	J Freyensee <james_p_freyensee@...ux.intel.com>
To:	weiyj_lk@....com, Keith Busch <keith.busch@...el.com>,
	Jens Axboe <axboe@...com>, Christoph Hellwig <hch@....de>
Cc:	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	linux-kernel@...r.kernel.org, linux-nvme@...ts.infradead.org
Subject: Re: [PATCH -next] nvme-rdma: fix the return value of
 nvme_rdma_reinit_request()

On Tue, 2016-07-12 at 11:06 +0000, weiyj_lk@....com wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> PTR_ERR should be applied before its argument is reassigned,
> otherwise the
> return value will be set to 0, not error code.

Another good catch.

Reviewed-by: Jay Freyensee <james_p_freyensee@...ux.intel.com>

> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

>  	if (IS_ERR(req->mr)) {
> -		req->mr = NULL;
>  		ret = PTR_ERR(req->mr);
> +		req->mr = NULL;
>  	}