linux-kernel - Re: [PATCH 14/34] mm, memcg: move memcg limit enforcement from zones to nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160712143828.GH5881@cmpxchg.org>
Date:	Tue, 12 Jul 2016 10:38:28 -0400
From:	Johannes Weiner <hannes@...xchg.org>
To:	Mel Gorman <mgorman@...hsingularity.net>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux-MM <linux-mm@...ck.org>, Rik van Riel <riel@...riel.com>,
	Vlastimil Babka <vbabka@...e.cz>,
	Minchan Kim <minchan@...nel.org>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 14/34] mm, memcg: move memcg limit enforcement from zones
 to nodes

On Fri, Jul 08, 2016 at 10:34:50AM +0100, Mel Gorman wrote:
> Memcg needs adjustment after moving LRUs to the node. Limits are tracked
> per memcg but the soft-limit excess is tracked per zone. As global page
> reclaim is based on the node, it is easy to imagine a situation where
> a zone soft limit is exceeded even though the memcg limit is fine.
> 
> This patch moves the soft limit tree the node.  Technically, all the variable
> names should also change but people are already familiar by the meaning of
> "mz" even if "mn" would be a more appropriate name now.
> 
> Signed-off-by: Mel Gorman <mgorman@...hsingularity.net>
> Acked-by: Michal Hocko <mhocko@...e.com>

Yep, the soft limit tracking scope needs to match the reclaim scope.

Nice patch :)

Acked-by: Johannes Weiner <hannes@...xchg.org>