linux-kernel - Re: [PATCH 44/93] clocksource/drivers/time-armada-370-xp: Convert init function to return error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1607121718150.4083@nanos>
Date:	Tue, 12 Jul 2016 17:18:57 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Anna-Maria Gleixner <anna-maria@...utronix.de>
cc:	Daniel Lezcano <daniel.lezcano@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 44/93] clocksource/drivers/time-armada-370-xp: Convert
 init function to return error

On Tue, 12 Jul 2016, Anna-Maria Gleixner wrote:
> On Thu, 7 Jul 2016, Daniel Lezcano wrote:
> > +	res = armada_370_xp_timer_setup(this_cpu_ptr(armada_370_xp_evt));
> > +	if (!res) {
> 
> I think the "!" is a mistake, because armada_370_xp_timer_setup()
> returns zero. See delta patch fixing this below.

Yes it is wrong.

Care to send a proper patch with a proper changelog?
 
Thanks,

	tglx

> 8<-------------------
> --- a/drivers/clocksource/time-armada-370-xp.c
> +++ b/drivers/clocksource/time-armada-370-xp.c
> @@ -342,7 +342,7 @@ static int __init armada_370_xp_timer_co
>  	}
>  
>  	res = armada_370_xp_timer_setup(this_cpu_ptr(armada_370_xp_evt));
> -	if (!res) {
> +	if (res) {
>  		pr_err("Failed to setup timer");
>  		return res;
>  	}
>