linux-kernel - Re: [PATCH v9 3/7] arm64: cpuidle: drop __init section marker to arm_cpuidle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160712152319.GG22183@e104818-lin.cambridge.arm.com>
Date:	Tue, 12 Jul 2016 16:23:19 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Sudeep Holla <sudeep.holla@....com>
Cc:	ACPI List <linux-acpi@...r.kernel.org>,
	"Rafael J . Wysocki" <rjw@...ysocki.net>,
	Mark Rutland <mark.rutland@....com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
	Prashanth Prakash <pprakash@...eaurora.org>,
	Al Stone <al.stone@...aro.org>,
	Vikas Sajjan <vikas.cha.sajjan@....com>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Ashwin Chaugule <ashwin.chaugule@...aro.org>,
	ALKML <linux-arm-kernel@...ts.infradead.org>,
	Sunil <sunil.vl@....com>
Subject: Re: [PATCH v9 3/7] arm64: cpuidle: drop __init section marker to
 arm_cpuidle_init

On Fri, Jul 08, 2016 at 06:07:54PM +0100, Sudeep Holla wrote:
> Commit ea389daa7fd9 ("arm64: cpuidle: add __init section marker to
> arm_cpuidle_init") added the __init annotation to arm_cpuidle_init
> as it was not needed after booting which was correct at that time.
> 
> However with the introduction of ACPI LPI support, this will be used
> from cpuhotplug path in ACPI processor driver.
> 
> This patch drops the __init annotation from arm_cpuidle_init to avoid
> the following warning:
> 
> WARNING: vmlinux.o(.text+0x113c8): Section mismatch in reference from the
> 	function acpi_processor_ffh_lpi_probe() to the function
> 	.init.text:arm_cpuidle_init()
> The function acpi_processor_ffh_lpi_probe() references
> the function __init arm_cpuidle_init().
> This is often because acpi_processor_ffh_lpi_probe lacks a __init
> annotation or the annotation of arm_cpuidle_init is wrong.
> 
> Cc: Mark Rutland <mark.rutland@....com>
> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@....com>
> Signed-off-by: Sudeep Holla <sudeep.holla@....com>

Acked-by: Catalin Marinas <catalin.marinas@....com>