linux-kernel - RE: [PATCH 1/2] crypto: vmx - Adding asm subroutines for XTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D5F4F62C4@AcuExch.aculab.com>
Date:	Tue, 12 Jul 2016 16:19:42 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Paulo Flabiano Smorigo' <pfsmorigo@...ux.vnet.ibm.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"Leonidas S. Barbosa" <leosilva@...ux.vnet.ibm.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Paul Mackerras <paulus@...ba.org>,
	"open list:IBM Power VMX Cryptographic instructions" 
	<linux-crypto@...r.kernel.org>,
	"open list:LINUX FOR POWERPC 32-BIT AND 64-BIT" 
	<linuxppc-dev@...ts.ozlabs.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: RE: [PATCH 1/2] crypto: vmx - Adding asm subroutines for XTS

From: Paulo Flabiano Smorigo
> Sent: 11 July 2016 20:08
> 
> This patch add XTS subroutines using VMX-crypto driver.
> 
> It gives a boost of 20 times using XTS.
> 
> These code has been adopted from OpenSSL project in collaboration
> with the original author (Andy Polyakov <appro@...nssl.org>).

Yep, typical openssl code. 1000+ lines of uncommented impenetrable assembler.
There is 0 chance of anyone ever checking this does what it should.

	David