linux-kernel - Re: 答复: BUG: INTx is assered unexpectly when unload AHCI driver with MSIx support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20160712173003.GM3190@htj.duckdns.org>
Date:	Tue, 12 Jul 2016 13:30:03 -0400
From:	"tj@...nel.org" <tj@...nel.org>
To:	Pang Raymond <Raymond_rule@...mail.com>
Cc:	linux ide <linux-ide@...r.kernel.org>,
	linux kernel <linux-kernel@...r.kernel.org>
Subject: Re: 答复: BUG: INTx is assered
 unexpectly when unload AHCI driver with MSIx support.

Hello,

On Mon, Jul 11, 2016 at 05:16:00AM +0000, Pang Raymond wrote:
> static irqreturn_t  ahci_multi_irqs_intr_hard(int irq,
> void *dev_instance)
> {
>       //  omitting unconcerned codes here
>       //  ...
>            status = readl(port_mmio + PORT_IRQ_STAT);
>            writel(status, port_mmio + PORT_IRQ_STAT);
> 
>       // add patch code here.
> +         writel(1 << ap->port_no, ap->host->iomap + HOST_IRQ_STAT);
> 
>       // ...

I think it'd be better to avoid adding stuff to the hot path.  This
only matters when the device is shut down, right?  Can't it just be
cleared in the driver cleanup path?

Thanks.

-- 
tejun