linux-kernel - Re: [PATCH] drm/panel: Remove the get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 Jul 2016 11:26:29 -0700
From:	Eric Anholt <eric@...olt.net>
To:	Thierry Reding <thierry.reding@...il.com>
Cc:	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	David Airlie <airlied@...ux.ie>
Subject: Re: [PATCH] drm/panel: Remove the get_timings() function.

Thierry Reding <thierry.reding@...il.com> writes:

> On Wed, Jun 01, 2016 at 12:18:01PM -0700, Eric Anholt wrote:
>> It appears to have no callers.
>> 
>> Signed-off-by: Eric Anholt <eric@...olt.net>
>> ---
>>  drivers/gpu/drm/panel/panel-simple.c | 18 ------------------
>>  include/drm/drm_panel.h              |  4 ----
>>  2 files changed, 22 deletions(-)
>
> Looks like I never replied to this, though I remember at least making up
> the reply in my head.
>
> The reason why I'd like to keep this is that it's technically the right
> interface for display drivers to use. It was introduced in order to fix
> some of the short-comings of ->get_modes(), though it seems like there
> simply hasn't been a need so far for drivers to do this.

OK.  That makes some sense then.  I was writing a new panel driver, and
it was confusing to have this unused code in panel-simple that I was
deriving from.

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)