linux-kernel - Re: [PATCH] device-tree: nexus7: Set phy mode to otg instead of host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160712183628.GF23833@tuxbot>
Date:	Tue, 12 Jul 2016 11:36:28 -0700
From:	Bjorn Andersson <bjorn.andersson@...aro.org>
To:	John Stultz <john.stultz@...aro.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Andy Gross <agross@...eaurora.org>,
	Stephen Boyd <stephen.boyd@...aro.org>,
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH] device-tree: nexus7: Set phy mode to otg instead of host

On Fri 01 Jul 22:33 PDT 2016, John Stultz wrote:

> In order to have the usb phy work in gadget mode, override
> the default host mode with otg mode.
> 
> This allows gadget mode to work w/o any hacks to the dtsi file.
> 
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Andy Gross <agross@...eaurora.org>
> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Cc: Stephen Boyd <stephen.boyd@...aro.org>
> Cc: linux-arm-msm@...r.kernel.org
> Cc: devicetree@...r.kernel.org
> Signed-off-by: John Stultz <john.stultz@...aro.org>
> ---
>  arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
> index 7b05f07..94e9cbb 100644
> --- a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
> +++ b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
> @@ -253,6 +253,7 @@
>  			vddcx-supply	= <&pm8921_s3>;
>  			v3p3-supply	= <&pm8921_l3>;
>  			v1p8-supply	= <&pm8921_l4>;
> +			dr_mode		= "otg";

Wouldn't this be the standard case for the first/primary USB on most
8064s? Looks like both the ifc6410 and  sd600eval has OTG support on the
micro-usb.

Andy, how about we just change the dtsi instead?

Regards,
Bjorn