linux-kernel - Re: Minor PKRU bug?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bdb6c72a-9119-968f-9d85-c0db59835db7@zytor.com>
Date:	Tue, 12 Jul 2016 15:55:48 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Dave Hansen <dave.hansen@...ux.intel.com>,
	Andy Lutomirski <luto@...capital.net>, X86 ML <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: Minor PKRU bug?

On 07/12/16 08:32, Dave Hansen wrote:
> On 07/09/2016 02:27 PM, Andy Lutomirski wrote:
>> is_prefetch in arch/x86/mm/fault.c can be called on a user address
>> that's not readable due to PKRU.  This could break it.  You might need
>> to add a get_user_exec or similar.
> 
> Thanks for the heads-up.  I think I'll just need a version that does
> something along the lines of stac/clac, but with PKRU.
> 
> I think I can do it with an "_exec" variant of probe_kernel_address(),
> but it's a bit messy.
> 

Can this particular codepath even be executed on a PKRU-equipped
machine?  I thought it was a bug fix for a specific AMD CPU line.

	-hpa