linux-kernel - Re: [PATCH 29/66] tools lib traceevent: Use str_error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Jul 2016 20:32:18 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	David Ahern <dsahern@...il.com>, Jiri Olsa <jolsa@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Wang Nan <wangnan0@...wei.com>
Subject: Re: [PATCH 29/66] tools lib traceevent: Use str_error_r()

Em Tue, Jul 12, 2016 at 07:25:19PM -0400, Steven Rostedt escreveu:
> On Tue, 12 Jul 2016 20:14:24 -0300
> Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> 
> > Em Tue, Jul 12, 2016 at 07:11:08PM -0400, Steven Rostedt escreveu:
> > > On Tue, 12 Jul 2016 19:40:04 -0300 Arnaldo Carvalho de Melo <acme@...nel.org> wrote:  
> > > > To make it portable to non-glibc systems, that follow the XSI variant
> > > > instead of the GNU specific one that gets in place when _GNU_SOURCE is
> > > > defined.  
> > 
> > > >  #include "event-parse.h"
> > > > @@ -6131,12 +6132,7 @@ int pevent_strerror(struct pevent *pevent __maybe_unused,
> > > > +		str_error_r(errnum, buf, buflen);
> > > >  		return 0;  

> > > What library is used with this? When I port this over to trace-cmd
> > > (which is still needed as I develop this there), it fails to build.
> > > "undefined reference to str_error_r"  

> > tools/lib/str_error_r.c

> > Forgot about the out of tree copy :-\
 
> Yeah, we really need to make this into a real library. I haven't had
> the time to do that. Hopefully in August I can talk with some people at

What exactly do you mean by that? To grab a copy of what is in tools/
and have it turned into a library somewhere else?

Or to freeze its interfaces and create an .so with a committed to ABI?

I kind of like the way it is now... :-)

> LinuxCon to see the best way to go about doing that.
> 
> Anyway, I may just take that file and port it to trace-cmd.

Yeah, that would solve this specific case.

- Arnaldo